[FLINK-37086] Clean up should remove all autoscaler state #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1996fanrui
approved these changes
Jan 13, 2025
Member
1996fanrui
left a comment
1996fanrui
left a comment
There was a problem hiding this comment.
Thanks @gyfora for the great and quick fix!
All changes LGTM, feel free to merge it if you think it's ready.
Contributor
Author
|
Thanks @1996fanrui I am going to test the 2 PRs together manually, then merge them :) |
Contributor
|
Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The autoscaler cleanup logic currently does not actually delete the state of the job from the state store only the cache. This can cause leaks in some cases and unintended retrieval of wrong state if the job is deleted then restarted.
Brief change log
Verifying this change
Unit tests have been extended to cover this more.
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation